Skip to content

Autocomplete complete used functions and constants#606

Open
Declspeck wants to merge 41 commits intofelixfbecker:masterfrom
Declspeck:autocomplete-complete-used-functions-and-constants
Open

Autocomplete complete used functions and constants#606
Declspeck wants to merge 41 commits intofelixfbecker:masterfrom
Declspeck:autocomplete-complete-used-functions-and-constants

Conversation

@Declspeck
Copy link
Contributor

@Declspeck Declspeck commented Feb 24, 2018

This add completion for

use function SomeNamespace\some_function;
use const SomeNamespace\SOME_CONST;

some_fun| // Completes to some_function
SOME_CONS| // Completes to SOME_CONST

This is based on #605 (Note - not the speedup PR, but another continuation of it), so this cannot be merged before #605 and #599 are merged.

nicolasmure and others added 30 commits November 13, 2017 20:18
@nicolasmure
speedup autocomplete with ReadableIndex::getDefinitionsForNamespace
2d91ee8
@nicolasmure
update tests
b7c7128
@nicolasmure
speedup static access autocomplete
6d725a2
@nicolasmure
cleanup
18f2f4c
@nicolasmure
globalDefinitions cache to speedup autocomplete
17602aa
@nicolasmure
also remove empty namespace index
6d30035
@nicolasmure
store definitions under the namespaceDefinitions cache key directly
ca0caf1
@nicolasmure
use Generators to get definitions without wasting memory
8768b69
@nicolasmure
also yield URIs to save memory
8801edb
@nicolasmure
add example of indexed definitions
6a41a7f
@nicolasmure
avoid useless array
6a36828
@nicolasmure
use of null coalescing operator
e34d8e1
@nicolasmure
use correct terminology
14f840b
@nicolasmure
consider the merge of felixfbecker#511
e9fd572
@nicolasmure
use tree representation index
d1f85f1
@nicolasmure
fix definitions storage collision (member / non member)
188a5df
@nicolasmure
use a single array to store definitions
cacde1e
@nicolasmure
cleanup
e162d94
@felixfbecker
Fix formatting
7437d30
@felixfbecker
Correct some docblocks
b118c77
@nicolasmure
cache is backward compatible
b3f30f3
@felixfbecker
Merge branch 'master' into feature/autocomplete-speedup
7511e25
@nicolasmure
use string concatenation instead of sprintf
fcdf791
@felixfbecker
Merge branch 'master' into feature/autocomplete-speedup
3bda390
@felixfbecker
Cleanup
b03950c
@nicolasmure
fix definition removal
97ec127
@nicolasmure
differenciate member and non member definitions
48bbbb5
@felixfbecker
Merge branch 'master' into feature/autocomplete-speedup
67dd980
@felixfbecker
Revert "differenciate member and non member definitions"
91ca99a 
This reverts commit 48bbbb5.
@felixfbecker
perf: get direct children
fa67f84
felixfbecker and others added 11 commits November 23, 2017 02:38
@codecov
Copy link

codecov bot commented Feb 24, 2018 •
edited by ghost
Loading

Codecov Report

Merging #606 into master will increase coverage by 0.35%.
The diff coverage is 90.79%.

@@             Coverage Diff              @@
##             master     #606      +/-   ##
============================================
+ Coverage     81.63%   81.99%   +0.35%     
- Complexity      910      948      +38     
============================================
  Files            61       61              
  Lines          2075     2233     +158     
============================================
+ Hits           1694     1831     +137     
- Misses          381      402      +21
Impacted Files Coverage Δ Complexity Δ
src/Server/TextDocument.php 75.55% <100%> (+0.18%) 57 <0> (+1) ⬆️
src/Index/AbstractAggregateIndex.php 86.04% <71.42%> (-7.44%) 26 <6> (ø)
src/Index/Index.php 77.41% <82.5%> (+7.6%) 54 <32> (+32) ⬆️
src/FqnUtilities.php 83.87% <90.47%> (+13.87%) 0 <0> (ø) ⬇️
src/CompletionProvider.php 94.39% <96.85%> (-0.12%) 113 <74> (+5)

@Declspeck Declspeck mentioned this pull request Feb 24, 2018
Closed
@felixfbecker
Copy link
Owner

felixfbecker commented Nov 11, 2018

Is this still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

work needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Declspeck @felixfbecker @nicolasmure